Compilation errors in check_multifile

[m.hadfield]

With the multifile-checking code introduced a couple of days ago I'm getting compilation errors in check_multifile when the model is built in a configuration that requires the reading of forcing files:

Code: Select all

check_multifile.f90:68.33:

            ncname=BRY(ng)%files(Fcount)
                                 1
Warning: Legacy Extension: REAL array index at (1)
check_multifile.f90:93.18:

          updated=.FALSE.
                  1
Error: Can't convert LOGICAL(4) to REAL(4) at (1)
check_multifile.f90:112.35:

            ncname=FRC(i,ng)%files(Fcount)
                                   1
Warning: Legacy Extension: REAL array index at (1)

The first problem is that there is no implicit none statement in this file, so undeclared variables are given implicit types, leading to the errors above.

If I add an "implicit none" statement I find there are 3 undeclared variables: Fcount, lstr (both of integer type) and updated (logical). If I add local declarations for these then the model builds and runs OK, though I don't know if the multifile-checking is actually working as it should. I note that the variable "updated" is set to .FALSE. in a couple of places but is never used.

[hankseidel]

We ran into the same problem yesterday evening. Just getting ready to post and we saw your post. We will try your workaround.

Hank

[arango]

Yes, this was fixed. Actually, there were a parallel bug in distributed memory that took me couple of hours to find. See following ticket for more information. Please update.

[m.hadfield]

A minor remaining issue: looking at this...

https://www.myroms.org/svn/src/trunk/RO ... ultifile.F

...the variable lstr is still undeclared, and this is not picked up by the compiler because there is still no "implicit none".