WET_DRY compilation problem

General scientific issues regarding ROMS

Moderators: arango, robertson

Post Reply
Message
Author
ashbre
Posts: 21
Joined: Tue Apr 28, 2020 3:08 pm
Location: Florida Atlantic University

WET_DRY compilation problem

#1 Unread post by ashbre »

Hi there,

I'm having trouble compiling with the WET_DRY option on the latest source code. I get the following error:

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

get_wetdry.f90(142): error #5082: Syntax error, found IDENTIFIER 'VID' when expecting one of: ) ( , : <END-OF-STATEMENT> ; % [ . = / =>
INI(ng)Vid(idPwet)=Vindex
-------------^
get_wetdry.f90(151): error #5082: Syntax error, found IDENTIFIER 'VID' when expecting one of: ) ( , : <END-OF-STATEMENT> ; % [ . = / =>
INI(ng)Vid(idRwet)=Vindex
-------------^
get_wetdry.f90(160): error #5082: Syntax error, found IDENTIFIER 'VID' when expecting one of: ) ( , : <END-OF-STATEMENT> ; % [ . = / =>
INI(ng)Vid(idUwet)=Vindex
-------------^
get_wetdry.f90(169): error #5082: Syntax error, found IDENTIFIER 'VID' when expecting one of: ) ( , : <END-OF-STATEMENT> ; % [ . = / =>
INI(ng)Vid(idVwet)=Vindex
-------------^
get_wetdry.f90(186): error #5082: Syntax error, found IDENTIFIER 'VID' when expecting one of: :: ) ( , : * <END-OF-STATEMENT> ; . % (/ + - [ ] /) . = ' ** > ...
& Vname(1,idPwet), INI(ng)Vid(idPwet), &
------------------------------------------------^
get_wetdry.f90(209): error #5082: Syntax error, found IDENTIFIER 'VID' when expecting one of: :: ) ( , : * <END-OF-STATEMENT> ; . % (/ + - [ ] /) . = ' ** > ...
& Vname(1,idRwet), INI(ng)Vid(idRwet), &
------------------------------------------------^
get_wetdry.f90(232): error #5082: Syntax error, found IDENTIFIER 'VID' when expecting one of: :: ) ( , : * <END-OF-STATEMENT> ; . % (/ + - [ ] /) . = ' ** > ...
& Vname(1,idUwet), INI(ng)Vid(idUwet), &
------------------------------------------------^
get_wetdry.f90(255): error #5082: Syntax error, found IDENTIFIER 'VID' when expecting one of: :: ) ( , : * <END-OF-STATEMENT> ; . % (/ + - [ ] /) . = ' ** > ...
& Vname(1,idVwet), INI(ng)Vid(idVwet), &

------------------------------------------------^
get_wetdry.f90(31): error #6404: This name does not have a type, and must have an explicit type. [GET_GRID]
PUBLIC :: get_grid
-----------------^
get_wetdry.f90(32): error #6404: This name does not have a type, and must have an explicit type. [GET_GRID_NF90]
PRIVATE :: get_grid_nf90
-----------------^
get_wetdry.f90(186): error #6200: A colon (:) is not valid in this context.
& Vname(1,idPwet), INI(ng)Vid(idPwet), &
-----------------------------------------^
get_wetdry.f90(185): error #6284: There is no matching specific function for this generic function reference. [NF_FREAD2D]
status=nf_fread2d(ng, model, ncname, INI(ng)%ncid, &
-------------^
get_wetdry.f90(209): error #6200: A colon (:) is not valid in this context.
& Vname(1,idRwet), INI(ng)Vid(idRwet), &
-----------------------------------------^
get_wetdry.f90(208): error #6284: There is no matching specific function for this generic function reference. [NF_FREAD2D]
status=nf_fread2d(ng, model, ncname, INI(ng)%ncid, &
-------------^
get_wetdry.f90(232): error #6200: A colon (:) is not valid in this context.
& Vname(1,idUwet), INI(ng)Vid(idUwet), &
-----------------------------------------^
get_wetdry.f90(231): error #6284: There is no matching specific function for this generic function reference. [NF_FREAD2D]
status=nf_fread2d(ng, model, ncname, INI(ng)%ncid, &
-------------^
get_wetdry.f90(255): error #6200: A colon (:) is not valid in this context.
& Vname(1,idVwet), INI(ng)Vid(idVwet), &
-----------------------------------------^
get_wetdry.f90(254): error #6284: There is no matching specific function for this generic function reference. [NF_FREAD2D]
status=nf_fread2d(ng, model, ncname, INI(ng)%ncid, &
-------------^
compilation aborted for get_wetdry.f90 (code 1)
make: *** [/mnt/beegfs/home/abrereton/SF_NESTED_ROMS/Build_roms/get_wetdry.o] Error 1
make: *** Waiting for unfinished jobs....

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%


Here is my header file:


%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%


** svn $Id: pulley.h 719 2014-03-13 22:25:13Z arango $
*******************************************************************************
** Copyright (c) 2002-2014 The ROMS/TOMS Group **
** Licensed under a MIT/X style license **
** See License_ROMS.txt **
*******************************************************************************
**
** Options for North East North America Application.
**
** Application flag: PULLEY
** Input script: ocean_pulley.in
*/

#define UV_ADV
#define UV_U3HADVECTION
#define UV_C4VADVECTION
#define UV_COR
#define UV_VIS2
#define UV_QDRAG
#undef TS_U3HADVECTION
#undef TS_C4VADVECTION
#define TS_MPDATA
#undef TS_A4HADVECTION
#undef TS_A4VADVECTION
#define TS_DIF2
#undef TS_DIF4
#define SALINITY
#define NONLIN_EOS
#define QCORRECTION
#define SCORRECTION
#define BULK_FLUXES
#define EMINUSP
#define LONGWAVE
#define SOLAR_SOURCE
#undef PJ_GRADPQ4
#define DJ_GRADPS
#define SOLVE3D
#define CURVGRID
#define MASKING
#undef BODYFORCE
#define AVERAGES
#undef DIAGNOSTICS_UV
#undef SPLINES
#undef PERFECT_RESTART
#undef RADIATION_2D
#define ANA_BSFLUX
#define ANA_BTFLUX
#define MIX_GEO_UV
#define MIX_GEO_TS

#define MY25_MIXING
#ifdef MY25_MIXING
# define N2S2_HORAVG
# define KANTHA_CLAYSON
# define K_C4ADVECTION
# define CANTON_A
#endif
#undef LMD_MIXING
#ifdef LMD_MIXING
# define LMD_RIMIX
# define LMD_CONVEC
# undef LMD_SKPP
# undef LMD_BKPP
# define LMD_NONLOCAL
#endif
#undef GLS_MIXING
#ifdef GLS_MIXING
# define RI_HORAVG
# define RI_VERAVG
#endif
# define SSH_TIDES
# define UV_TIDES
# define RAMP_TIDES
# define ADD_M2OBC
# define ADD_FSOBC

#define WET_DRY
#define MASKING
#undef BIO_FENNEL

#ifdef BIO_FENNEL
# define ANA_SPFLUX
# define ANA_BPFLUX
# undef ANA_SRFLUX
# define CARBON
# define DENITRIFICATION
# undef BIO_SEDIMENT
#endif
#define DIAGNOSTICS
#define DIAGNOSTICS_BIO

#undef FLOATS
#undef FLOAT_VWALK

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%


Any help would be greatly appreciated!

All the best,
Ash
Top
User avatar
kate
Posts: 4091
Joined: Wed Jul 02, 2003 5:29 pm
Location: CFOS/UAF, USA

Re: WET_DRY compilation problem

#2 Unread post by kate »

I would look for idRwet and friends in your varinfo.dat. They need to be there.
Top
ashbre
Posts: 21
Joined: Tue Apr 28, 2020 3:08 pm
Location: Florida Atlantic University

Re: WET_DRY compilation problem

#3 Unread post by ashbre »

Thanks for the quick reply!

They are all there, does the compilation interact with varinfo.dat?

All the best,
Ash
Top
User avatar
kate
Posts: 4091
Joined: Wed Jul 02, 2003 5:29 pm
Location: CFOS/UAF, USA

Re: WET_DRY compilation problem

#4 Unread post by kate »

Actually, it looks like some bugs have been introduced. This:

Code: Select all

INI(ng)Vid(idVwet)=Vindex
is not the proper syntax, as the compiler notes. Try

Code: Select all

INI(ng)%Vid(idVwet)=Vindex
instead.
Top
User avatar
wilkin
Posts: 922
Joined: Mon Apr 28, 2003 5:44 pm
Location: Rutgers University
Contact:
Contact wilkin

Re: WET_DRY compilation problem

#5 Unread post by wilkin »

Is your code up to date? I'm not seeing that syntax error in my code.
John Wilkin: DMCS Rutgers University
71 Dudley Rd, New Brunswick, NJ 08901-8521, USA. ph: 609-630-0559 jwilkin@rutgers.edu
Top
ashbre
Posts: 21
Joined: Tue Apr 28, 2020 3:08 pm
Location: Florida Atlantic University

Re: WET_DRY compilation problem

#6 Unread post by ashbre »

Hi there,

I ran a svn update this morning and the get_wetdry.f90 code updated and now most of the errors are gone (rev 1067). I'm just left with the following:

get_wetdry.f90(31): error #6404: This name does not have a type, and must have an explicit type. [GET_GRID]
PUBLIC :: get_grid
-----------------^
get_wetdry.f90(32): error #6404: This name does not have a type, and must have an explicit type. [GET_GRID_NF90]
PRIVATE :: get_grid_nf90
-----------------^
compilation aborted for get_wetdry.f90 (code 1)

Thanks for getting back to me so quickly as usual!
Ash
Top
User avatar
arango
Site Admin
Posts: 1367
Joined: Wed Feb 26, 2003 4:41 pm
Location: DMCS, Rutgers University
Contact:
Contact arango

Re: WET_DRY compilation problem

#7 Unread post by arango »

Yes, thank you for reporting this bug. It is already fixed. Please check the following :arrow: trac ticket. Please update your code. I will have to check what your other error is. It looks weird. Those routines are private inside the get_grid_mod (get_grid.F). Have you made changes to get_grid.F? I checked the code and I don't see anything wrong. It compiles for me.
Top
User avatar
arango
Site Admin
Posts: 1367
Joined: Wed Feb 26, 2003 4:41 pm
Location: DMCS, Rutgers University
Contact:
Contact arango

Re: WET_DRY compilation problem

#8 Unread post by arango »

Okay, I see it now. It is fixed. Please update again. Thank you!
Top
ashbre
Posts: 21
Joined: Tue Apr 28, 2020 3:08 pm
Location: Florida Atlantic University

Re: WET_DRY compilation problem

#9 Unread post by ashbre »

Thanks! One more ...

initial.f90(174): error #6631: A non-optional actual argument must be present when invoking a procedure with an explicit interface. [INIREC]
CALL get_wetdry (ng, iNLM, IniRec(ng))
---------------^
compilation aborted for initial.f90 (code 1)
Top
User avatar
arango
Site Admin
Posts: 1367
Joined: Wed Feb 26, 2003 4:41 pm
Location: DMCS, Rutgers University
Contact:
Contact arango

Re: WET_DRY compilation problem

#10 Unread post by arango »

Okay, thanks. I am getting annoyed with this routine. It needed to be modified because of PIO. I rarely use WET_DRY. Please update again.
Top
ashbre
Posts: 21
Joined: Tue Apr 28, 2020 3:08 pm
Location: Florida Atlantic University

Re: WET_DRY compilation problem

#11 Unread post by ashbre »

Works perfectly! Thanks for the quick fix, it's much appreciated!
Top
Post Reply

Return to “ROMS Discussion”